-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(topicsSelection): use headless ui component #519
refactor(topicsSelection): use headless ui component #519
Conversation
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you! Maintainer checklist
|
5799c42
to
1be0c67
Compare
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
frontend/i18n/en-US.json
Outdated
@@ -847,5 +847,13 @@ | |||
"title": "Our Supporters" | |||
} | |||
} | |||
}, | |||
"global": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bmartins-42! FYI this will get switched after this gets merged in. I made the decision to flatten the i18n JSON so that we can search for the keys and their usages in a full codebase search. This will go into the top most _common
name scheme :) More details for this are in #511.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Come to think of it though, _global
makes more sense :) Thanks for the suggestion!
@bmartins-42, checking it out now: on selection the topics aren't staying the cta color 🤔 Is the color just not updating, or is the selection getting canceled. And another question: is the user able to select more than one? |
Thanks so much for the work here! It's looking great! 😊 Seems like we're very close to closing this out :) |
Strange, I will check this tomorrow. |
- Define topic interface and default values - Integrate last ui interface from figma - Rework component with HeadlessUI combobox
ce5aa75
to
70431c4
Compare
@andrewtavis I fixed the issue, I didn't clean up correctly my work... It should be ok, I also updated the i18n file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so great, @bmartins-42 😊 Really am so grateful for the help here! :) :) I'll try to finalize the hover coloration in #521 so that it's really looking good for the sync on Saturday 🚀
I'll write some comments on how this is working for accessibility in the issue, as I think that further changes should be in a new one as this 100% solves the original issue!
Thank you!
Contributor checklist
Description
This task was about reworking the code to use Headless UI and integrate the latest visual from Figma
Related issue
#276